Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Code completion hint for Two.Renderer.setSize() method #683

Open
cdaein opened this issue Jan 6, 2023 · 3 comments
Open

Comments

@cdaein
Copy link

cdaein commented Jan 6, 2023

It's not really a bug, but I am not getting code completion (VSCode IntelliSense) when using Two.Renderer.setSize() method in TypeScript.

Renderer gets completion hint:
Screenshot 2023-01-06 at 2 44 40 PM

setSize doesn't:
Screenshot 2023-01-06 at 2 44 52 PM

and after writing the method, no documentation appears:
Screenshot 2023-01-06 at 2 45 05 PM

@cdaein cdaein changed the title [Enhancement] Code completion hint for Teo.Renderer.setSize() method [Enhancement] Code completion hint for Two.Renderer.setSize() method Jan 6, 2023
@jonobr1
Copy link
Owner

jonobr1 commented Jan 7, 2023

Hmm, those completion hints are incorrect. Renderers don't have settings or SketchSettings. I'll take a look into this and it should be easy to add the completion hints for methods and properties to the renderers. Thanks

@cdaein
Copy link
Author

cdaein commented Jan 7, 2023

thanks for the reply. those settings and SketchSetting are the what I defined, so no issues with them. 🙂

@jonobr1
Copy link
Owner

jonobr1 commented Jan 9, 2023

This patch should fix your issue: #684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants