Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version issue with windows native install powershell script #318

Open
neuroptics opened this issue Mar 7, 2022 · 4 comments
Open

Version issue with windows native install powershell script #318

neuroptics opened this issue Mar 7, 2022 · 4 comments

Comments

@neuroptics
Copy link

Just perusing, not worried about performance at the moment and not wanting to mess with WSL....

In https://raw.githubusercontent.com/jonescompneurolab/hnn/master/installer/windows/hnn-windows.ps1

Line 365: "Rename-Item .\hnn-1.3.1 .\hnn"

Throws an error with newer versions (currently 1.3.2).

Should be an easy fix, thanks!

@ntolley
Copy link
Contributor

ntolley commented Mar 8, 2022

@neuroptics thanks for raising the issue! Unfortunately I don't have a windows build to test this out, is this where the error is raised or did you manually edit the script yourself?

@jasmainak @rythorpe do you have a windows build to test if this install runs properly through powershell?

@jasmainak
Copy link
Collaborator

unfortunately I don't, if @neuroptics makes a pull request after testing it out, I'm happy to merge it though

@rythorpe
Copy link
Contributor

rythorpe commented Mar 8, 2022

I don't either. If we need to though, I can dust off my dual boot windows/ubuntu machine and try for a clean native install on windows 10.

@neuroptics
Copy link
Author

Thanks everyone! I can confirm that changing the 1 to a 2 works.

I have zero experience with powershell but it looks like the permanent fix should be:
Rename-Item .\hnn-* .\hnn

I'll test it on one of our other machines when I get a chance unless someone else beats me to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants