Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poisson input causes descrepancy with tutorial #264

Open
rythorpe opened this issue Nov 24, 2020 · 4 comments
Open

poisson input causes descrepancy with tutorial #264

rythorpe opened this issue Nov 24, 2020 · 4 comments

Comments

@rythorpe
Copy link
Contributor

During the process of determining if hnn-core outputs the same results over multiple trials as hnn (i.e., as governed by assigning random states), we determined that hnn no longer recreates the same dynamics for Poisson inputs as shown in the gamma tutorial Figure 4.

@jasmainak, @cjayb, and I bisected out 90d992a as the commit that caused hnn to diverge from the results shown currently in the gamma tutorial. This might be a good time to discuss

  1. the "correct" implementation of Poisson inputs (see also the bug fixed in MRG: improve feeds hnn-core#204)
  2. how/when we should update our ground truth representation of Poisson-generated hnn dipoles on the tutorial webpage
@jasmainak
Copy link
Collaborator

@stephanie-r-jones @samnemo we need your inputs here

@samnemo
Copy link
Member

samnemo commented Nov 25, 2020 via email

@stephanie-r-jones
Copy link
Member

Can we discuss during our HNN meeting Tuesday morning? Starts at 9:10am.

@samnemo
Copy link
Member

samnemo commented Nov 25, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants