Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Spikes and ExtInput from spikefn.py #237

Open
blakecaldwell opened this issue Sep 18, 2020 · 2 comments
Open

remove Spikes and ExtInput from spikefn.py #237

blakecaldwell opened this issue Sep 18, 2020 · 2 comments

Comments

@blakecaldwell
Copy link
Member

blakecaldwell commented Sep 18, 2020 •
edited

Depends on #232

Both of these classes can be removed if the hnn-core Spike class is relied upon.
@blakecaldwell blakecaldwell changed the title remove Spikes and ExtInput from spikefn.py remove Spikes and ExtInput from spikefn.py Sep 18, 2020
@blakecaldwell blakecaldwell mentioned this issue Sep 19, 2020
Closed
@blakecaldwell
Copy link
Member Author

@rythorpe letting you know about this planned code update in HNN GUI. nothing to be done at the moment.

@blakecaldwell blakecaldwell mentioned this issue Mar 30, 2021
Closed
@blakecaldwell
Copy link
Member Author

Now that the integration code is merged, this issue is ready to be looked at again. The whole spikefn.py file could be deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blakecaldwell