Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What is the issue with named defines exactly? #25

Open
jfrux opened this issue Nov 7, 2017 · 2 comments
Open

What is the issue with named defines exactly? #25

jfrux opened this issue Nov 7, 2017 · 2 comments

Comments

@jfrux
Copy link

jfrux commented Nov 7, 2017

Trying to convert the bbc TAL library to ES6 and it uses them.
Do the names do much as far as code goes?
@jonbretman
Copy link
Owner

Hey Josh,

Sorry for the incredibly delayed response. No they don't do anything in an ES Module world so I thought the best thing to do would be to blow up as depending on how they are used it might cause issues.

@madiyetov
Copy link
Contributor

Hey @jonbretman May be adding some flag for this will be useful. I have more than one hundred modules and I am regexing and replacing it all. What if just ignore modules names?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jfrux @jonbretman @madiyetov