Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function asyncio_redis.Connection.create() hangs if connection can't be established #128

Open
vikt0rs opened this issue Apr 26, 2019 · 2 comments

Comments

@vikt0rs
Copy link

vikt0rs commented Apr 26, 2019

If someone tries to create a connection to the wrong host (for example) function asyncio_redis.Connection.create() hangs forever and the user gets no error message.

From my side, it happens in _reconnect() method [0] because of the while True: loop - it has no exit condition on connection error and it retries connection attempts forever

[0] - https://github.com/jonathanslenders/asyncio-redis/blob/master/asyncio_redis/connection.py#L93

@vikt0rs
Copy link
Author

vikt0rs commented Apr 26, 2019

Pull request #118 looks like a solution for this issue.
@jonathanslenders - any hope that the PR will be merged someday?

@mateuszmandera
Copy link

Can this be closed, considering f2ae635 was merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants