Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

depend upon and invoke upstream nushell code directly (not via spawning new nu processes) #7

Open
jokeyrhyme opened this issue Sep 28, 2023 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@jokeyrhyme
Copy link
Owner

jokeyrhyme commented Sep 28, 2023

  • we should explore this first, as it might not be worth the trade-offs
  • how significant is the performance benefit?
  • how frequently would upstream code break backwards compatibility (i.e. what is the ongoing burden)
@jokeyrhyme jokeyrhyme added enhancement New feature or request question Further information is requested labels Sep 28, 2023
@jokeyrhyme
Copy link
Owner Author

mentioned here: nushell/vscode-nushell-lang#117 (comment)

@jokeyrhyme
Copy link
Owner Author

From Discord: https://discord.com/channels/601130461678272522/1066353495638278194/1161785815710576700

we'd like to have nuls built into nushell. i'm guessing that probably means a nu-language-server crate in our main repo. we'd like to integrate more fully with nushell so that the language server doesn't have to shell out at all. it just accesses the functions that the --ide flags call. then we see it being run as nu --lsp. the key here is that people don't have to have any separate installs. if they have nushell, they have the language server. we're making this up as we go so who knows how that could change in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant