Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should "public" always be omitted in TypeScript? #859

Open
brian3kb opened this issue Apr 19, 2018 · 1 comment
Open

Should "public" always be omitted in TypeScript? #859

brian3kb opened this issue Apr 19, 2018 · 1 comment

Comments

@brian3kb
Copy link

The style guide omits the public keyword in all the examples, but I can't see an actual rule that says: "Don't use the public keyword, as everything is public by default to TypeScript."

I know that some prefer to use public in all cases, but I find this can create noise in the codebase on property heavy models, should we have a rule that advises one way or the other?

Thanks!

@alterfo
Copy link

alterfo commented Aug 21, 2018

Don't use the public keyword
Why? everything is public by default to TypeScript.
Why? there is no such tooling checking or linting it
Why? ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants