Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record execution order #19

Open
joealcorn opened this issue Aug 1, 2018 · 2 comments
Open

Record execution order #19

joealcorn opened this issue Aug 1, 2018 · 2 comments

Comments

@joealcorn
Copy link
Owner

When #13 was shipped we started running control & candidates in a random order. This is in order to weed out any issues caused by hidden dependencies between them.

However we never record the execution order anywhere, which could be a helpful piece of information when debugging these issues, so we should probably start doing that somehow.

@nickdirienzo
Copy link
Contributor

How would you like to record them? Would logging be sufficient?

For example:

logger.debug('Executing control: {}'.format(control_fn.__name__) 
logger.debug('Executing candidate: {}'.format(candidate_fn.__name__)

The library could also pull the fully qualified name as well, if that'd be more helpful. What do you think?

@joealcorn
Copy link
Owner Author

joealcorn commented Aug 8, 2018

I don't think logging is enough - it should be available on the Result instance so that it's available during publishing.

@joealcorn joealcorn reopened this Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants