Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parrot Overload #340

Open
jmhobbs opened this issue Mar 13, 2019 · 10 comments
Open

Parrot Overload #340

jmhobbs opened this issue Mar 13, 2019 · 10 comments
Assignees

Comments

@jmhobbs
Copy link
Owner

jmhobbs commented Mar 13, 2019

There are.... so many parrots. The website is dragging on mobile, and spinning fans on desktop.

We need to split things up and load them in chunks, or do multiple pages or something.

Any input is appreciated!

@jmhobbs jmhobbs self-assigned this Mar 13, 2019
@uberchemist
Copy link
Contributor

I take full responsibility 😭😭😭

Flag Parrots probably need their own page...

@jmhobbs
Copy link
Owner Author

jmhobbs commented Mar 14, 2019

It’s a glorious problem to have!!!

@francoislg
Copy link
Contributor

Wouldn't a simple solution work for now, and see whether this needs to be improved later?

I think putting the Flag Parrot behind a lazy collapsible section would be fine and quite easy :)

@jmhobbs
Copy link
Owner Author

jmhobbs commented Mar 16, 2019

I'm sticking them on their own page for now, happy to accept PR's that improve it.

Screen Shot 2019-03-15 at 7 06 07 PM

@uberchemist
Copy link
Contributor

Looks good to me! Would the 6 parrots around the button load randomly? That would be cool!

@jmhobbs
Copy link
Owner Author

jmhobbs commented Mar 18, 2019

That would be cool! I'll see how much trouble that would be to do.

@jmhobbs
Copy link
Owner Author

jmhobbs commented Mar 20, 2019

Done! I'll leave this open for other ideas if anyone has them.

@uberchemist
Copy link
Contributor

Random parrot flags! I love it! ❤️

@uberchemist
Copy link
Contributor

Also, for the flags page, there's some inconsistency in the naming. For example, some are named in the format of "[Country Adjective] Parrot" while others use "[Country Name] Parrot" and the rest just use "[Country Name]". We should choose one format and make it uniform. Also, I'd recommend renaming the informal "America Parrot" to the more universal "United States Parrot".

@jmhobbs
Copy link
Owner Author

jmhobbs commented Mar 27, 2019

Fixed those up in #351 @uberchemist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants