Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgltf_write to buffer ignores options -> can't create an in-memory GLB #192

Open
pplux opened this issue Nov 17, 2022 · 0 comments
Open

Comments

@pplux
Copy link

pplux commented Nov 17, 2022

The function cgltf_write here:

(void)options;

ignores the first argument options.

As an user, I thought that setting the options, and in particular telling cgltf to generate a glb, would work. But since the options parameter is completely ignored, obviously it doesn't output glb to memory either.

It is fine for cgltf not to be able to generate a GLB in memory, it is a very easy format to do manually, but ignoring the options completely really confuses users IMHO. I would a) honor the options, b) if options are not used remove it as a parameter to not mislead the user into thinking it serves a purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant