You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As an user, I thought that setting the options, and in particular telling cgltf to generate a glb, would work. But since the options parameter is completely ignored, obviously it doesn't output glb to memory either.
It is fine for cgltf not to be able to generate a GLB in memory, it is a very easy format to do manually, but ignoring the options completely really confuses users IMHO. I would a) honor the options, b) if options are not used remove it as a parameter to not mislead the user into thinking it serves a purpose.
The text was updated successfully, but these errors were encountered:
The function cgltf_write here:
cgltf/cgltf_write.h
Line 1259 in 561455e
ignores the first argument options.
As an user, I thought that setting the options, and in particular telling cgltf to generate a glb, would work. But since the options parameter is completely ignored, obviously it doesn't output glb to memory either.
It is fine for cgltf not to be able to generate a GLB in memory, it is a very easy format to do manually, but ignoring the options completely really confuses users IMHO. I would a) honor the options, b) if options are not used remove it as a parameter to not mislead the user into thinking it serves a purpose.
The text was updated successfully, but these errors were encountered: