Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use fsnotify instead of polling for autoreload #77

Open
cyberhck opened this issue Apr 26, 2022 · 2 comments
Open

use fsnotify instead of polling for autoreload #77

cyberhck opened this issue Apr 26, 2022 · 2 comments
Assignees

Comments

@cyberhck
Copy link

Describe the feature

configor should reload config when the file changes and not poll it every once in a while.

Motivation

Currently, it does polling, if I do it too aggressively it calls my function too often, if not, then my credentials are rotated, but I won't know about it.

A much nicer API would be to use fsnotify instead. It has good support and it only calls if the file has changed.

Related Issues

@cyberhck
Copy link
Author

hey everyone, we're happy to send a PR IF you guys will review and accept.

@cyberhck
Copy link
Author

@jinzhu is this project still maintained? Looks like there's literally a PR which solves this issue and there has been no comments from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants