Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality of Life Updates // v5 Preflight #542

Merged
merged 9 commits into from
Feb 1, 2024

Conversation

irfan-dahir
Copy link
Collaborator

  • Updated dependencies
  • Added PHPDocs gen script composer generate-docs (Needs to have phpdocs installed)
  • Goutte replaced with respective Symfony dependencies (Resolves Replace fabpot/goutte with symfony/browser-kit #523)
  • Fixes broken tests
  • Added missing test fixtures that were not being cached properly causing the tests to break over time
  • Updated PHPCS rules (PSR12, PHP82Migration, PER-CS)
  • ⚠️Minimum PHP requirement is now ^8.2 (Code auto-updated to PHP ^8.2 via PHPCS)
  • Coding Standard is now PSR12 (auto-updated via PHPCS, previously PSR2)

Documentation can now be generated via composer generate-docs.
Documentation repo: https://github.com/jikan-me/jikan-docs
Documentation website: https://docs.jikan.moe/

@irfan-dahir irfan-dahir added this to the 5.0.0 milestone Feb 1, 2024
@irfan-dahir irfan-dahir self-assigned this Feb 1, 2024
@irfan-dahir irfan-dahir changed the base branch from master to 5.0.0 February 1, 2024 08:14
@irfan-dahir irfan-dahir merged commit d059ad6 into 5.0.0 Feb 1, 2024
3 checks passed
@irfan-dahir irfan-dahir deleted the enhancement/replace-goutte branch February 1, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace fabpot/goutte with symfony/browser-kit
1 participant