Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder images should not be parsed #488

Open
ToshY opened this issue Oct 24, 2022 · 0 comments
Open

Placeholder images should not be parsed #488

ToshY opened this issue Oct 24, 2022 · 0 comments
Labels
enhancement refactoring/speeding up
Milestone

Comments

@ToshY
Copy link
Contributor

ToshY commented Oct 24, 2022

Problem

Request to characters from anime returns questionmark_23.gif images for characters, which is just a placeholder image. These placeholder images are apparently still being parsed and returned. It would make more sense to return null instead, as there is no image for this character.

The same seems for other categories as well, like voice actors, shows, users, companies, etc.

Reproduction

Example 47917

Expectation

Possibly the parser should check specifically for a list of image placeholders, like questionmark_23.gif (character & voice actor search), questionmark_50.gif (user search), qm_50.gif (anime search), placeholder.png (company search), na.gif (club search), etc. and return null if so.

Version
v3.3.2

@irfan-dahir irfan-dahir added the enhancement refactoring/speeding up label Oct 25, 2022
@irfan-dahir irfan-dahir added this to the 5.0.0 milestone Jul 21, 2023
@irfan-dahir irfan-dahir mentioned this issue Jul 21, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement refactoring/speeding up
Projects
Status: No status
Development

No branches or pull requests

2 participants