Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I really like it, but can I trust its quality? #3

Open
Byron opened this issue Feb 25, 2018 · 4 comments
Open

I really like it, but can I trust its quality? #3

Byron opened this issue Feb 25, 2018 · 4 comments

Comments

@Byron
Copy link

Byron commented Feb 25, 2018

First of all, I like what it can do and was about to install it when I noticed that there doesn't seem to be a single test.

Something that came to my mind is to test it entirely on CLI level to emulate how people would use it. Here is an example of journey level tests, which looks like this when run (it's all just bash).

Do you consider this this as much of a maintenance problem as I do?
Please don't feel pressured or criticized, I really am interested to learn about the way this tool is/was developed.

@dataf3l
Copy link

dataf3l commented Feb 25, 2018

Hey Byron, why not just write the tests?, and send them as a pull request? it could a fun exercise, and you get to play around in Rust?

@Byron
Copy link
Author

Byron commented Feb 25, 2018

Thanks, but I am already very busy exercising on share secrets safely :D!

@jhspetersson
Copy link
Owner

There should definitely be tests! First lexer and parser will be covered. Sample files to check basic scenarios go next. And finally we'll need few Vagrant VMs to test some more specific cases (not sure that all of VMs could be easily created/distributed).

@Byron
Copy link
Author

Byron commented Feb 25, 2018

Sounds good, and good luck!
If you think docker will also do, instead of using full-blown VMs, you could try the respective travis-ci feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants