Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of static executor service #84

Open
acogoluegnes opened this issue Oct 5, 2017 · 2 comments
Open

Get rid of static executor service #84

acogoluegnes opened this issue Oct 5, 2017 · 2 comments
Labels

Comments

@acogoluegnes
Copy link
Collaborator

See #80 (comment)

@DimaGolomozy
Copy link

DimaGolomozy commented Oct 5, 2017

ChannelHandler also uses this executor,
But I think the problem can be solved when close/abort are invoked.
If they are invoked from ConnectionHandler class, then the executor should be stopped.

@acogoluegnes
Copy link
Collaborator Author

The static executor service scopes all the connections created in the process. Stopping it for a connection would make the recovery impossible for all the other connections created in the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants