-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maximum fading time #7
Comments
Hi Ivan, The decision was purely because, for most needs, I didn't expect the interval to be longer than 65 seconds. I don't think it should be a problem for you to change it to a long data type. If you do this, let me know how it works! Sent from my iPhone
|
I tried to do this changement... I tried to set up the interval over 70000 and more, but I can't see any difference...It works, but the fade time seems not change. I don't know.... |
That's odd. How long does it seem to fade? |
Another way is dividing millis() to 1000. In this case precision will be in seconds, and max time ~18 hr. |
hi all, and thanks jgillick for this great library the unsigned long method didnt work for me either, but i eventually figured r00tGER dividing the millis(); i made my fader to run up to 600 seconds by dividing all the millis(); in the .cpp file
and dividing the MIN_INTERVAL in the .h file as well (default was 20):
now the FADE_TIME is in milliseconds*10 so 2 seconds are now 200 and not 2000 , just to keep in mind |
Hi |
@GavC666 that makes sense. Mind submitting a pull request with those changes and I'll merge it into the library? |
Hello
thank a lot for this library, is very helpful.
I have only a question...I saw into the library that you define the interval (time of fading) like an unsigned int.
In this way the maximum time that I can set up it's about 65 second.
I need an interval like 1 hour... Is possible to change the interval from unsigned int to unsigned long?
Or you have choose this type of variable for a specific reason?
Thanks in advance.
Ivan
The text was updated successfully, but these errors were encountered: