Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the PR scan open new PRs? #619

Open
jasminjohal-els opened this issue Jan 18, 2024 · 1 comment
Open

Does the PR scan open new PRs? #619

jasminjohal-els opened this issue Jan 18, 2024 · 1 comment
Labels
question Further information is requested

Comments

@jasminjohal-els
Copy link

I noticed the following setting in the template frogbot-scan-pull-request.yml file:

          # [Optional, Default: "FALSE"]
          # If TRUE, Frogbot creates a single pull request with all the fixes.
          # If false, Frogbot creates a separate pull request for each fix.
          # JF_GIT_AGGREGATE_FIXES: "FALSE"

https://github.com/jfrog/documentation/blob/77008ab7c9402ea1a7eb6b99c016074cd1ada5fe/jfrog-applications/frogbot/templates/github-actions/frogbot-scan-pull-request.yml#L116-L119

This implies it will create PRs to resolve issues detected by the PR scan. Is this actually the case? Shouldn't this only be true for the repo scan?

Also, since the default value is already "FALSE", perhaps # JF_GIT_AGGREGATE_FIXES: "FALSE" should be changed to # JF_GIT_AGGREGATE_FIXES: "TRUE". frogbot-scan-repository.yml would also need to be updated with this change.

@jasminjohal-els jasminjohal-els added the question Further information is requested label Jan 18, 2024
@eranturgeman
Copy link
Contributor

Hello @jasminjohal-els, thank you for getting in touch.
Setting JF_GIT_AGGREGATE_FIXES to TRUE doesn't imply the creation of a PR for the scan-pr results.
When this flag is TRUE, it signifies that if multiple vulnerabilities are identified, their fixes will be consolidated into a single PR. Conversely, if set to FALSE, each vulnerability will be addressed in individual PRs.
Hence, the default value is FALSE, and it should stay that way for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants