Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Skip" is Cut Short on Samsung Galaxy Z Fold4 #143

Open
Bilal-Abdeen opened this issue Jun 23, 2023 · 3 comments
Open

"Skip" is Cut Short on Samsung Galaxy Z Fold4 #143

Bilal-Abdeen opened this issue Jun 23, 2023 · 3 comments

Comments

@Bilal-Abdeen
Copy link

Bilal-Abdeen commented Jun 23, 2023

On Samsung Galaxy Z Fold4 (when it is folded.), the Skip button is cut short (only "Ski" is displayed.)

@Bilal-Abdeen
Copy link
Author

Bilal-Abdeen commented Jun 23, 2023

As a workaround, I used a custom component for Skip:

const skipComponent = ({ isLight, skipLabel, ...props }) => (
<View style={{ marginStart: 10, minWidth: 30, }}>
	<Text { ...props }
		onPress={() => {onSkip();}}
	>{skipLabel}</Text>
</View>);

<Onboarding
   ...
   SkipButtonComponent={skipComponent}
/> 

@AlexMachin1997
Copy link

I don't believe this is specific to the Samsung Galaxy Z Fold4.

I'm just updating my project and I've noticed that the page title, skip and next button are all cut short for some reason.

This is what it look's like a Google Pixel 6a currently:

Screenshot_20231105-135658

@Jay-Salisbury
Copy link

Also have this problem on a Google Pixel 5a with Next, so perhaps it's an Android styles issue.

This is the code that worked for me, passing a component to nextLabel as there is no onNext equivalent to onSkip that I could see:

const NextComponent = () => (
    <View row centerV right flex>
      <Text primary marginR-2 right style={{ minWidth: 120, textAlign: 'right' }} >
        {services.t.do('onboard.next')}      // Returns 'Next' or other translations
      </Text>
      <Icon name="chevron-forward-outline" size={30} color={Colors.primary} /> // Right arrow added
    </View>
  );

<Onboarding
      nextLabel={NextComponent()}
      ...
``` `

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants