Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending the player further #66

Open
Mecanik opened this issue Aug 14, 2022 · 3 comments
Open

Extending the player further #66

Mecanik opened this issue Aug 14, 2022 · 3 comments

Comments

@Mecanik
Copy link

Mecanik commented Aug 14, 2022

Hello,

Amazing work! Very impressed. Please excuse my noob questions as I`m quite new to podcasts and I am trying to setup a PoC project.

  1. Is it possible to add these "waveforms" (like SoundCloud has)?

image

  1. Is it possible to add volume control?
  2. Is it possible to add download button?
  3. Ultimately, some sharing buttons?

Happy to pitch in with whatever I can, cashflow or code (need to learn more about audio files first lol).

Many thanks!

@Mecanik
Copy link
Author

Mecanik commented Aug 14, 2022

I also forgot to add:

  1. Possible to extend the layout as sticky on the bottom of the page? Like https://podcasts.google.com/.

@Mecanik
Copy link
Author

Mecanik commented Aug 14, 2022

I also forgot to add:

  1. Playlist support?

@jessuni
Copy link
Owner

jessuni commented Aug 26, 2022

Thanks for the ideas!

  1. I actually tried to implement this feature when first starting this project. But generating waveform from client-side for podcasts isn't really practical. The better solution would be generating the waveform data from the server-side, as SoundCloud does, mapping the data with the timeline and sending the data to client-side. But then we need to decide the data structure passed to Shikwasa. Since there's no feature requests of this kind before, I didn't dive into the details. But if you could provide some waveform data samples generated from some popular libraries we can discuss this further.
  2. Duplicate of no controls on increase/decrese the volume #23. I just can't convince myself of writing this feature even to this day.
  3. Supported. https://github.com/jessuni/shikwasa#download
  4. Do you mean sharing the current audio, or the page that contains the audio player? If it's the latter, would it be better to share from the page instead of the player? Just a quick thought.
  5. Supported. https://github.com/jessuni/shikwasa#fixed
  6. Duplicate of Playlist #28. As many ppl need this feature, it will be supported in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants