-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repeated scrobbles if jellyfin is left idle without stopping playback #59
Comments
Hey @alexcannan thanks for reporting this. Are you able to share the Jellyfin logs for a period where the multiple submissions are occurring. I suspect that the Pause event fires the "Playback Stopped" event. This is the event we listen for when calculating the logic to determine if we should send to LastFM (https://github.com/jesseward/jellyfin-plugin-lastfm/blob/master/Jellyfin.Plugin.Lastfm/ServerEntryPoint.cs#L102-L171). I am interested in seeing the logs to determine what keepalive event is firing to continually trigger such a failure. |
Hi there, thanks for the info. I've found some repeated Here is an excerpt from the logs:
I am now curious if these repeated events are a bug from jellyfin itself, or the jellyfin media player app I use on my laptop. I'll attempt to recreate this state using the web player. |
Tangential, but I'm also noticing the logs seems to be falsely reporting that the scrobbles have failed. These scrobbles show up on my last.fm page as expected.
|
Same problem here, it's just enough to pause the player and resume playback later to get the track scrobbled twice. As Alex says, all scrobbles have an error, maybe that's what causing the double scrobbles?
|
I don't know if this has changed, but from looking at the doc api, it seems that the ignored attribute is not a boolean but an enumeration (https://www.last.fm/api/scrobbling#filtered-requests) but the plugin is considering it a boolean, so that might be causing the error that later triggers the error message, but the error is happening decoding the response, which doesn't necessarily mean that the scrobbling failed. In this case, it didn't. All this after 5 minutes checking, so please take this with a grain of salt, I might be off :) |
I had another instance of the
repeat ad infinum... To me, it seems like the root of this issue is from these repeated |
I disagree, the issue is that the plugin thinks that the scrobbling failed, but it didn't. This is because it's not parsing the json response correctly. Fixing that should fix all related issues. |
Happening to me as well. The logs show the |
A new release was published at https://github.com/jesseward/jellyfin-plugin-lastfm/releases/tag/8.1.0.0 . This was working towards 10.9.0 compatibility, but I believe i also addressed the JSON/schema issue in the Last.FM scrobble API response... You can install via the JF plugin repo, or install directly from the GitHub release page. If JF doesn't prompt for an upgrade of the plugin, try removing the plugin and reinstalling via the plugin repo selector. |
Should be fixed in #64 , please reopen if you're still seeing issues |
I've noticed an issue with duplicated scrobbles when my jellyfin client is left idle without explicitly stopping the playback, just pausing.
Repeated scrobbles seem to happen every 1 to 2 hours.
My reproduction steps so far are:
I would be interested in pinpointing and fixing this issue myself, but I wanted to solicit comments first, if anyone had insight into how this could be happening.
The text was updated successfully, but these errors were encountered: