Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable stride != 1 for SConv2dLSTM #86

Open
jeshraghian opened this issue Dec 30, 2021 · 0 comments
Open

Enable stride != 1 for SConv2dLSTM #86

jeshraghian opened this issue Dec 30, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@jeshraghian
Copy link
Owner

SConv2dLSTM currently concatenates the hidden cell with the input cell, applies a single nn.Conv2d function of channel length 4*out_channel
The output is then split into 4 chunks (along the channel dimension), which are fed to each of the 4 LSTM gates
This means HxW of the hidden cell must be equal to HxW of input

Stride != 1 causes HxW to no longer be equal.
To fix this, a stride argument can trigger the conv to take place before concatenation of the hidden state mem and input x.
Far less efficient than running all conv operations in one hit, though I don't yet see a way around this.

@ahenkes1 ahenkes1 added the enhancement New feature or request label Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants