{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":663342686,"defaultBranch":"master","name":"bitcoin","ownerLogin":"jeon3029","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-07-07T05:00:49.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/10026516?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1688706053.534494","currentOid":""},"activityList":{"items":[{"before":"160d23677ad799cf9b493eaa923b2ac080c3fb8e","after":"207220ce8b767d8efdb5abf042ecf23d846ded73","ref":"refs/heads/master","pushedAt":"2024-01-25T06:16:37.000Z","pushType":"push","commitsCount":352,"pusher":{"login":"jeon3029","name":null,"path":"/jeon3029","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10026516?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29302: wallet: clarify replaced_by_txid and replaces_txid in help output\n\nff54314d4abed3bf9a78daf785a01c63af15c69d wallet: clarify replaced_by_txid and replaces_txid in help output (marco)\n\nPull request description:\n\n Resolves issue #27781\n\nACKs for top commit:\n achow101:\n ACK ff54314d4abed3bf9a78daf785a01c63af15c69d\n ryanofsky:\n Code review ACK ff54314d4abed3bf9a78daf785a01c63af15c69d. Seems like a helpful clarification\n\nTree-SHA512: b13a0e24505dfaee083467ac6f357b96460b5d1841dc29c4df4a503c290d379cef3d50fcc76f33bbc95741f484dd9d2461b0c2e8bdebf57a8a72edfbeece2a79","shortMessageHtmlLink":"Merge bitcoin#29302: wallet: clarify replaced_by_txid and replaces_tx…"}},{"before":"75135c673ee61b61eb36b1b8aa8b4ddbe8da55e1","after":"160d23677ad799cf9b493eaa923b2ac080c3fb8e","ref":"refs/heads/master","pushedAt":"2023-12-03T10:17:28.000Z","pushType":"push","commitsCount":1565,"pusher":{"login":"jeon3029","name":null,"path":"/jeon3029","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10026516?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#28851: build: Patch Qt to handle minimum macOS version properly\n\n05aca093819be276ac7d648472c6ed5c7d235cc5 build: Patch Qt to handle minimum macOS version properly (Hennadii Stepanov)\n\nPull request description:\n\n This PR is:\n - required to [switch](https://github.com/bitcoin/bitcoin/pull/28622) to macOS 14 SDK (Xcode 15).\n - an alternative to https://github.com/bitcoin/bitcoin/pull/28732 and https://github.com/bitcoin/bitcoin/pull/28775.\n\n Qt relies on the `__MAC_OS_X_VERSION_MIN_REQUIRED` macro, which is set in the `AvailabilityInternal.h` SDK header to\n the value provided by the Clang driver from the `-mmacos-version-min` / `-mmacosx-version-min` option.\n\n Xcode 12 SDK expects the OS-specific `__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__` macro:\n ```c++\n #ifndef __MAC_OS_X_VERSION_MIN_REQUIRED\n #ifdef __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__\n /* compiler for Mac OS X sets __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ */\n #define __MAC_OS_X_VERSION_MIN_REQUIRED __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__\n #endif\n #endif /* __MAC_OS_X_VERSION_MIN_REQUIRED*/\n ```\n\n In the other hand, Xcode 15 SDK expects a general `__ENVIRONMENT_OS_VERSION_MIN_REQUIRED__` macro:\n ```c++\n #ifndef __MAC_OS_X_VERSION_MIN_REQUIRED\n #if defined(__has_builtin) && __has_builtin(__is_target_os)\n #if __is_target_os(macos)\n #define __MAC_OS_X_VERSION_MIN_REQUIRED __ENVIRONMENT_OS_VERSION_MIN_REQUIRED__\n #define __MAC_OS_X_VERSION_MAX_ALLOWED __MAC_14_0\n #endif\n #elif __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__\n #define __MAC_OS_X_VERSION_MIN_REQUIRED __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__\n #define __MAC_OS_X_VERSION_MAX_ALLOWED __MAC_14_0\n #endif /* __has_builtin(__is_target_os) && __is_target_os(macos) */\n #endif /* __MAC_OS_X_VERSION_MIN_REQUIRED */\n ```\n\n The latter macro is not provided by LLVM Clang until https://github.com/llvm/llvm-project/commit/c8e2dd8c6f490b68e41fe663b44535a8a21dfeab, which is available in Clang 17.\n\n The suggested patch makes Qt \"borrow\" the `__MAC_OS_X_VERSION_MIN_REQUIRED` value from `MAC_OS_X_VERSION_MIN_REQUIRED`, which is set in the `AvailabilityMacros.h` SDK header.\n\nACKs for top commit:\n maflcko:\n lgtm ACK 05aca093819be276ac7d648472c6ed5c7d235cc5\n\nTree-SHA512: 8891aefde4b8a48885abf0648f4ec71a22f7fcfca1e17ebb8c70ce1ef44751ea5db6b8b652de6ee8a716ca5f96f720fef01600bc23986162d0146c946e2e8743","shortMessageHtmlLink":"Merge bitcoin#28851: build: Patch Qt to handle minimum macOS version …"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAD6JyZUgA","startCursor":null,"endCursor":null}},"title":"Activity · jeon3029/bitcoin"}