Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug report #20

Open
hahaliu005 opened this issue Aug 5, 2019 · 4 comments · Fixed by #21 · May be fixed by #22
Open

Bug report #20

hahaliu005 opened this issue Aug 5, 2019 · 4 comments · Fixed by #21 · May be fixed by #22

Comments

@hahaliu005
Copy link

hahaliu005 commented Aug 5, 2019 •
edited

File /src/File.php line 117:

            $file = new UploadedFile($filePath, $originalName, 'blob', count($filePath), UPLOAD_ERR_OK, true);

count($filePath) may report error in php7.3 or upper, because count parameter must be array or countable object.
@jenky jenky mentioned this issue Aug 5, 2019
Merged
@jenky jenky closed this as completed in #21 Aug 5, 2019
@hahaliu005
Copy link
Author

Hi:
There's still problem , I'am sure UploadedFile must need 6 params, and the 4th param is the file size of path. I think this would be correct.

$file = new UploadedFile($filePath, $originalName, 'blob', filesize($filePath), UPLOAD_ERR_OK, true);

@jenky
Copy link
Owner

jenky commented Aug 5, 2019

Which laravel version are you using

@jenky jenky reopened this Aug 5, 2019
@hahaliu005
Copy link
Author

I use Laravel 5.5

@jenky
Copy link
Owner

jenky commented Aug 5, 2019

It looks like UploadedFile from symfony/http-foundation 3 has 6 params while version 4 has 5. I will take more time to work on this

jenky added a commit that referenced this issue Aug 5, 2019
@jenky
Maintain UploadedFile backward compatibility
834626a 
Fix #20
@jenky jenky linked a pull request Aug 5, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jenky @hahaliu005