Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Errors vs Warnings #31

Open
ilinkuo opened this issue Jun 21, 2013 · 1 comment
Open

Feature Request: Errors vs Warnings #31

ilinkuo opened this issue Jun 21, 2013 · 1 comment

Comments

@ilinkuo
Copy link

ilinkuo commented Jun 21, 2013

It would be really nice if the violations-plugin could distinguish between warnings and errors. For example, with this output from csslint:

<issue line="173" char="192" severity="warning" reason="Use of !important" evidence=".tdaVideoPlayer .pageHeader .closeButton{text-decoration:none;text-transform:uppercase;color:#999;font-size:11px;font-family:HelveticaNeueW01-75Bold, Helvetica black, Arial black, sans-serif;font-weight:normal !important;background:url('../../images/icons/pageClose.png') 100% 50% no-repeat;padding-right:18px;display:inline-block;line-height:13px}"/>
    <issue line="189" char="414" severity="error" reason="Expected RBRACE at line 189, col 414." evidence=".tdaVideoPlayer .videoOverlayLayer.playPauseButton{width:42px;height:42px;margin:auto;top:50%;margin-top:-24px;background:url('../../images/icons/playerHoverPlay.png') 50% 50% no-repeat;filter:'progid:DXImageTransform.Microsoft.Alpha(opacity=50)';-moz-border-radius:50%;-webkit-border-radius:50%;-ms-border-radius:50%;border-radius:50%;opacity:.5;-ms-filter:'progid:DXImageTransform.Microsoft.Alpha(Opacity=(0.5)');filter:alpha(opacity=(0.5))}"/>

The current tabular output has 5 columns -- filename, l, m, h, number. These columns should be retained, but refer to errors only. A sixth column could be added for "warnings". All the existing logic for build failure should depend on the error number only, not the warnings or the total number of violations.

The chart should show both the total number of violations (errors + warnings) and the errors.

@Atomschinken
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants