Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pending status checks not shown #60

Open
borisivan opened this issue May 21, 2019 · 2 comments
Open

pending status checks not shown #60

borisivan opened this issue May 21, 2019 · 2 comments

Comments

@borisivan
Copy link

I have a repo with a required status check. When the PR receives a new commit, that required status check is created and pending -- it might not be set to success or failed until a later time.

But when I list all status checks across all commits, I see all the status checks that are passed/failed, but I don't see the required status check which is still pending. Is that not provided by github via the API, or is there something wrong here?

@borisivan
Copy link
Author

Learning more about how this works -- I suspect that github doesn't have a 'required' status as an existing status. The 'required' status list is just a different set of objects per branch defining which are required, and the github UI lists them in the PR next to the actual existing statuses, but that doesn't mean those are returned by the API. I would think they should be, but it looks like that's not the case.

If agreed, I guess we can close this, though I'd love to see this plugin enhanced or another plugin provide that information (required status per branch) so we can make use of it. The lack of that, combined with the 'isMergeable' not taking the required statuses into account, means that there isn't an existing solution to answer the question: "has this PR met it's requirements to be merged'? i.e. is it really mergeable?

@tamilselvanmp
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants