Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PullRequest global variable is not shown in Global Variable Reference page. #123

Open
Pldi23 opened this issue Sep 7, 2023 · 0 comments
Labels

Comments

@Pldi23
Copy link

Pldi23 commented Sep 7, 2023

Jenkins and plugins versions report

Environment
Paste the output here

What Operating System are you using (both controller, and any agents involved in the problem)?

I'm using mac, but it's not important.

Reproduction steps

Step 1. Navigate to {JENKINS_URL}/jenkins/job/{pipeline_job_name}/pipeline-syntax/globals and see the list of available global vars, but pullRequest var is missing.

Expected Results

When user navigate to {JENKINS_URL}/jenkins/job/{pipeline_job_name}/pipeline-syntax/globals pullRequest global variable should be listed.

Actual Results

When user navigate to {JENKINS_URL}/jenkins/job/{pipeline_job_name}/pipeline-syntax/globals pullRequest global variable is not listed.

Anything else?

I guess https://github.com/jenkinsci/pipeline-github-plugin/blob/master/src/main/java/org/jenkinsci/plugins/pipeline/github/PullRequestGlobalVariable.java#L15 should be an @Extension and description of all vars should be provided.

I think this improvement will significantly increase the use and recognition of the plugin.

@Pldi23 Pldi23 added the bug label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant