Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on latest/ directory #953

Open
daniel-beck opened this issue May 10, 2020 · 8 comments
Open

Remove dependency on latest/ directory #953

daniel-beck opened this issue May 10, 2020 · 8 comments

Comments

@daniel-beck
Copy link
Member

daniel-beck commented May 10, 2020

The update center will stop providing tiered latest/ directories soon.

Please adapt install-plugins.sh to work without that.

I had switched to the new version of the update site generator yesterday, and these issues were filed:
https://issues.jenkins-ci.org/browse/INFRA-2614
#952 (comment)

@slide
Copy link
Member

slide commented May 14, 2020

Can you give some details on what the structure will look like?

@daniel-beck
Copy link
Member Author

@slide It's unclear what you're asking. These directories will no longer be generated.

See e.g. https://issues.jenkins-ci.org/browse/INFRA-2615 for a change I plan to implement that will make the existence of update site tiers dependent on what plugins actually declare.

Instead, request /update-center.actual.json?version=2.xyz and download plugins from the URLs specified there.

@slide
Copy link
Member

slide commented May 15, 2020

Ok, that makes more sense.

@slide
Copy link
Member

slide commented May 15, 2020

One thing I noticed is that if you provide a bogus Jenkins version, e.g., https://updates.jenkins.io/update-center.actual.json?version=4.0 you still get update center information returned. I am not sure if this is desirable in all cases.

@daniel-beck
Copy link
Member Author

@slide In that particular case, we provide the current update site, treating it like the latest weekly. Seems reasonable. 2.0 will be redirected to 2.164, the non-existing 2.0.1 to stable-2.164.

We redirect all 1.x versions to the latest, but it really doesn't make that much of a difference anymore, upgrading core is the only thing that matters. Are you seeing other redirects that don't make sense?

@lemeurherve
Copy link
Member

@daniel-beck as the install-plugins.sh script has been removed since #1408, do you think this issue could be closed?

@daniel-beck
Copy link
Member Author

@lemeurherve Probably, do you know whether plugin-installation-manager-tool needs these? Superficially there are references to "latest", but I didn't look close enough to be confident about presence or absence of tiered latest dir references.

@timja
Copy link
Member

timja commented Oct 24, 2023

@lemeurherve Probably, do you know whether plugin-installation-manager-tool needs these? Superficially there are references to "latest", but I didn't look close enough to be confident about presence or absence of tiered latest dir references.

as far as I know it doesn't need them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants