Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also publish to GitHub container registry #1140

Open
timja opened this issue Jul 6, 2021 · 6 comments
Open

Also publish to GitHub container registry #1140

timja opened this issue Jul 6, 2021 · 6 comments

Comments

@timja
Copy link
Member

timja commented Jul 6, 2021

Any thoughts?

I've done an experiment here:
https://github.com/timja/jenkins-ci.org-docker/pkgs/container/jenkins

see https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry

Steps taken:

  • Logged in with a github pat (see above doc)
  • Pushed image
  • Went to packages on my profile and linked it to this repo (on my fork)
  • Updated the package setting to be public instead of private (one off change per image, not per tag)

The main benefit I see is there's pull metrics per tag.
It amazes me that docker hub does not provide this =/. I want to know if anyone actually uses e.g. centos or windows tags.

cc @dduportal @MarkEWaite @slide @olblak

@olblak
Copy link
Member

olblak commented Jul 6, 2021

I wouldn't leave dockerhub because well it's still the default place to go but I don't see any objection to push images to ghcr as well. I am using it for updatecli from here and it's working great

@slide
Copy link
Member

slide commented Jul 6, 2021

I also think we shouldn't leave dockerhub, people look there first for images. I think ALSO publishing to ghcr would be fine.

@timja timja changed the title Migrate to GitHub container registry? Also publish to GitHub container registry Jul 6, 2021
@MarkEWaite
Copy link
Contributor

I think publishing to GitHub container registry is a great idea in addition to Dockerhub.

@dduportal
Copy link
Contributor

+1 on this: with the recent addition of docker buildx bake, it should be easy on the pipeline side.

@timja since I recently got warned by GitHub that I'm consuming too much space, could you check the limitations (size/API rate) on the GitHub that we would have if we do so?

@timja
Copy link
Member Author

timja commented Sep 1, 2021

@olblak
Copy link
Member

olblak commented Sep 1, 2021

I am not aware of any limits and I would definitely be in favor to publish on ghrc.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants