Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classification files ignored if not below jsonReportDirectory #426

Open
KLBonn opened this issue Nov 15, 2022 · 3 comments
Open

Classification files ignored if not below jsonReportDirectory #426

KLBonn opened this issue Nov 15, 2022 · 3 comments

Comments

@KLBonn
Copy link
Contributor

KLBonn commented Nov 15, 2022

Describe your use-case which is not covered by existing documentation.

We wanted to use the classificationFilePattern argument in order to supply additional metadata to be displayed in the report.
However our .properties file kept getting ignored by cucumber-reporting plugin.

It took me quite some code-reading to discover why:
In CucumberReportPublisher#480 you save available property files below inputReportDirectory to directoryCache, so they can be evaluated later on.
However inputReportDirectory is based on plugin argument/setting jsonReportDirectory.

In our case jsonReportDirectory is set to Maven target subfolder, while the classification property file is residing in workspace root, so because of the above it never was included for the cache and subsequent processing. That was quite a surprise.

Could you add some appropriate advice in documentation, that (contrary to naming) jsonReportDirectory is not only effective for json reports, but also for classificationFilePattern parameter?

Reference any relevant documentation, other materials or issues/pull requests that can be used for inspiration.

No response

@damianszczepanik
Copy link
Member

Would you like to add PR for this ?

@KLBonn
Copy link
Contributor Author

KLBonn commented Nov 16, 2022

I can try, but I am not familiar at all with Jenkins plugin structure, .jelly files etc.

@KLBonn
Copy link
Contributor Author

KLBonn commented Nov 16, 2022

Done :)

Noticed the Json reports path also is mentioned at Wiki page https://github.com/jenkinsci/cucumber-reports-plugin/wiki/Detailed-Configuration#notes-on-configuration.
Should I propose / enter a respective hint there, too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants