Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for video embedding #355

Open
jgabriel98 opened this issue May 7, 2020 · 4 comments
Open

Support for video embedding #355

jgabriel98 opened this issue May 7, 2020 · 4 comments

Comments

@jgabriel98
Copy link

Is there a way to support video mime_type, be it 'video/mp4' or 'video/ogg', like introduced in version 4.10.0 of damianszczepanik cucumber-reporting ( on this commit ).

If yes, in which version this feature becomes available.

If not, would it be hard to implement this support feature?

@damianszczepanik
Copy link
Member

I'm happy to accept that feature if you prepare PR

@jgabriel98
Copy link
Author

jgabriel98 commented May 7, 2020

i think i can do it.
could you tell me in which file(s) the mime_types are? or something related to it. Just to work as an initial guide, because i cannot find it, and then i can handle it myself.

@jgabriel98 jgabriel98 changed the title Support for video embegding Support for video embedding May 8, 2020
@jgabriel98
Copy link
Author

i realized that it uses the damianszczepanik cucumber-reporting to generate the report.

i cannot find where is defined which version is used.
Also how can i build this repo? so then i can guide myself thorugh the code workflow ( and find where it calls cucumber-reporting to generates the report)

@damianszczepanik
Copy link
Member

Both are standard maven projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants