From 393f578ebddca204434e9f086d082da07cf89feb Mon Sep 17 00:00:00 2001
From: Mark Waite <mark.earl.waite@gmail.com>
Date: Fri, 21 Apr 2023 00:43:30 -0600
Subject: [PATCH] Revert "Bump maven-plugin from 3.16 to 3.21" (#181)

* Revert "Bump maven-plugin from 3.16 to 3.21"

* Explain maven plugin version pin in a comment

https://github.com/jenkinsci/bom/pull/1978 notes that the upgrade of
the optional dependency on the maven plugin from 3.16 to 3.21 caused
the Jenkins plugin bill of materials to need an explicit inclusion of
the Jenkins maven plugin into the plugin BOM.

That's not a desired change because the Jenkins maven plugin tests do
not pass when run in the Jenkins plugin BOM test suites.  We don't
want to invest the effort in the Jenkins maven plugin tests to make
them work in the Jenkins plugin BOM.

The https://github.com/jenkinsci/copyartifact-plugin/pull/174
dependabot proposed upgrade is being reverted to avoid the problem.
When dependabot next proposes an upgrade of this dependency, it can be
closed or evaluated as an incremental build in the Jenkins plugin BOM
before the upgrade is approved.
---
 pom.xml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 7e14a118..608096ac 100644
--- a/pom.xml
+++ b/pom.xml
@@ -51,7 +51,10 @@
       <dependency>
         <groupId>org.jenkins-ci.main</groupId>
         <artifactId>maven-plugin</artifactId>
-        <version>3.21</version>
+        <!-- Intentionally kept at 3.16 to not disrupt Jenkins plugin bill of materials -->
+        <!-- https://github.com/jenkinsci/bom/pull/1978#issuecomment-1516220549 -->
+        <!-- TODO: Before upgrading this version, must check that plugin bill of materials is unharmed -->
+        <version>3.16</version>
         <optional>true</optional>
       </dependency>
       <dependency>