readFile with default

[gaborbernat]

What feature do you want to see added?

Currenlty it's not possible to use readFile substition with a fallback value.

password: "${file:/data/secret/jenkins-password.txt:-fallback}"

Now this logs a warning.

Upstream changes

No response

[jetersen]

@gaborbernat can't find the docs but your basically using nested substitution wrong that's all. This is a supported feature.

We have some tests that uses nested substitution:

configuration-as-code-plugin/plugin/src/test/java/io/jenkins/plugins/casc/SecretSourceResolverTest.java

Line 315 in 099c739

String output = resolve("${base64:${readFile:${FOO}}}");

[gaborbernat]

That's not the same. That means use an env-var to set the file name. It does not set a default value for readFile without an env-var. https://github.com/jenkinsci/configuration-as-code-plugin/blob/master/docs/features/secrets.adoc#passing-secrets-through-variables suggest the default syntax should work for all not just env-vars.

[jetersen]

I mean what you want is this: ${${file:/data/secret/jenkins-password.txt}:-fallback}

[gaborbernat]

But that would log a nasty warning

configuration-as-code-plugin/plugin/src/main/java/io/jenkins/plugins/casc/SecretSourceResolver.java

Lines 175 to 178 in 099c739

	LOGGER.log(Level.WARNING, String.format(
	"Configuration import: Error looking up file '%s' with UTF-8 encoding. Will default to empty string",
	key), e);
	return null;

🤔 can I avoid that? As in this case the file missing is expected and handled.

[jetersen]

it gives a warning but it should work.

I think the warning here makes sense, please configure the file.

[jetersen]

What you're asking for will not be supported because we are using an Apache StrSubstitutor implementation.

Unless your willing to write a customized implementation.