Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile ENTRYFILE needs to be array #145

Open
chmac opened this issue Jan 26, 2022 · 3 comments
Open

Dockerfile ENTRYFILE needs to be array #145

chmac opened this issue Jan 26, 2022 · 3 comments

Comments

@chmac
Copy link
Contributor

chmac commented Jan 26, 2022

Following #144 I've been trying understand the docker docs on entrypoint vs cmd. Okay, think I got it.

I think the issue is that according to this and the docker docs the CMD value is ignored if ENTRYPOINT is a string. It needs to be an array I think.

If CMD is used to provide default arguments for the ENTRYPOINT instruction, both the CMD and ENTRYPOINT instructions should be specified with the JSON array format.

I think that means the CMD value in the xandikos dockerkfile is ignored.

I think the ENTRYPOINT could be as follows:

ENTRYPOINT ["python3", "-m", ":xandikos.web", "--port=8000", "--listen-address=0.0.0.0", "-d/data"]

But you probably want to double check that!

I think this explains why I didn't get the default directories created in docker.

@jelmer
Copy link
Owner

jelmer commented Mar 5, 2022

Are you still working on this?

@chmac
Copy link
Contributor Author

chmac commented Mar 5, 2022

An, I wasn't intending to work on it, I was just suggesting the change. I have only pulled your docker image but not built it locally so I figured it should be a quick test for you if you already have all the docker stuff setup.

@walkertraylor
Copy link
Contributor

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants