Don't set content type to null for mixed libraries during creation #5496
Conversation
|
Cloudflare Pages deployment
|
|
This will definitely break other functionality (in web) that depends on the mixed type being undefined. |
Would it be better then to change code that checks for mixed type to check for undefined type? Seems to just be a few places in the library scripts. As long as it's guaranteed that an undefined type always means mixed movies and shows then that should also work. |
|
I haven't had a chance to read over the related issue fully but we need to ensure that existing libraries with the undefined type continue to work as expected. |
|
Is there a technical reason to why mixed type is converted to other on creation? I have a quite big library with type set to mixed, but since trickplay doesn't work with 'other' #5490 and I'm not aware of any way to modify existing library type this is a potential serious issue if it would require rebuilding libraries with different type. I actually need mixed, because there are movies and television series in one library on purpose. I may find necessary to recreate my libraries but have to know if removing old library will also remove its content from already created playlists? Basically I have one giant playlist that sorts movies and tv shows for watching chronologically and this playlist points to movies and shows stored inside this one mixed type library. Example: library 1 (type: mixed): Now my playlist consists of all above so I can watch in order eg: So if I recreate my library and distribute files to separate folders without changing file names will my playlist continue to work as before or will it break (e.g. missing movies or removed items)? Sorry for this long wall of text but I would rather not have to recreate my entire 450+ elements playlist if I can avoid it. It was a long and tedious process to sort this list for chronological order. |
Changes
Removed code that set content type to null for mixed libraries during virtual folder creation.
This was added in 81d936f. There is no further information about what issue this fixed, however it is currently causing issues for parts of code that expect the content type to be correctly set.
I was not able to find any issues when creating a mixed library, viewing mixed library content, etc. after making this change but so much of the code has changed since 2015 it's hard to say if whatever issue that prompted this change has been fixed somewhere else or if it is just not obvious enough to find during preliminary testing.
Alternatively, code that checks for 'mixed' type could instead check for null.
Issues
Fixes #5490
Fixes jellyfin/jellyfin#11284
Also fixes related issues such as library sub-heading showing "Other" instead of "Mixed Movies and Shows."