Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing deprecated tabs in dashboard 10.9 #5484

Closed
shemanaev opened this issue May 12, 2024 · 5 comments
Closed

Missing deprecated tabs in dashboard 10.9 #5484

shemanaev opened this issue May 12, 2024 · 5 comments
Labels
bug Something isn't working regression We broke something
Milestone

Comments

@shemanaev
Copy link
Contributor

Describe The Bug

Is there any migration path for deprecated tabs functionality from?

<div style={isHidden ? { display: 'none' } : undefined}>
<div className='mainDrawer hide'>
<div className='mainDrawer-scrollContainer scrollContainer focuscontainer-y' />
</div>
<div className='skinHeader focuscontainer-x' />
<div className='mainDrawerHandle' />
</div>

Mainly interested in this method:

LibraryMenu.setTabs();

I've been using it in plugin UI (like it was implemented in Playback Reporting plugin) and now it appears to be broken (there are no more tabs in Playback Reporting).

Steps To Reproduce

Expected Behavior

Logs

Screenshots

10.8
10.8

10.9
10.9

System (please complete the following information):

  • Platform: Windows
  • Browser: Firefox
  • Jellyfin Version: 10.9

Additional Context

@Cloud9Developer
Copy link

Nice! was just looking for this! Any ETA on release with this fix?

@thornbill
Copy link
Member

Now 😎

@Cloud9Developer
Copy link

My hero!

@Kevinjil
Copy link

Hi @thornbill, the old behaviour does not seem to be fully restored, as noted in Kevinjil/Jellyfin.Xtream#99 (comment). Is it intended that you can no longer use ApiClient.getUrl("web/ConfigurationPage", "MyName") as tab href?

@thornbill
Copy link
Member

You should only specify the part of the path after the #

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression We broke something
Projects
Development

No branches or pull requests

4 participants