Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow generating sitemap_index files #300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ashmaroli
Copy link
Member

Resolves #295
In order to link multiple sitemap files.

TODO: Add documentation once implementation is approved.

@olifre
Copy link

olifre commented Oct 9, 2022

I tested this and it works perfectly well for me, an example configuration is shown e.g. at:
olifre/olifre.github.io@bff63b4
It does not seem to work with the standard Jekyll builder on GitHub, but that's probably since it seems to ignore selecting a specific branch. Works fine like a charm when testing it locally, including generation of appropriate robots.txt and allowing to change name of the index file.

Thanks! 👍

@ashmaroli
Copy link
Member Author

I tested this and it works perfectly well for me,

Thanks for testing, @olifre. Happy to know that the current implementation works for your use-case.
However, I wouldn't recommend using in production until this gets reviewed / merged at minimum.

@olifre
Copy link

olifre commented Oct 10, 2022

However, I wouldn't recommend using in production until this gets reviewed / merged at minimum.

Sure 😄. I was just trying it out locally and checked whether it would work with GitHub Pages, the commit right after the one I linked reverts the changes and I am using a manual workaround (hand-crafted files) for the time being.
Thanks again for the implementation!

@MilesCranmer
Copy link

Just pinging this – this is really useful, thanks again for submitting it. Could this be merged? (Who should we ping for a review?)

@yannickwurm
Copy link

bumping this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to add pages that are not in the project
4 participants