Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation improvements #495

Open
y377 opened this issue Aug 11, 2023 · 1 comment
Open

Documentation improvements #495

y377 opened this issue Aug 11, 2023 · 1 comment
Labels
pinned

Comments

@y377
Copy link
Member

y377 commented Aug 11, 2023 •
edited

Following the official document example, I realized that I need to improve it a bit, I've been following the steps on the official website since I got in touch with jekyll 2 years ago, so I got into the habit of doing it until I inadvertently found a problem:
When the jekyll-seo-tag plugin is enabled, the plugin also generates a <title>{{ page.title }} - {{ site.title }}</title> by default, which leads to duplicate titles, and I'd like to improve the docs to remind future generations!

template.html：

<!-- Begin Jekyll SEO tag v{{ seo_tag.version }} -->
{% if seo_tag.title? %}
<title>{{ seo_tag.title }}</title>
{% endif %}

head.html：

<head>
<meta name="viewport" content="width=device-width, initial-scale=1">
<meta charset="utf-8">
<title>{{ page.title }} - {{ site.title }}</title>
.......

My English is not good, and I look forward to the improved reminder as follows:

If you enable jekyll-seo-tag, make sure there is no <title> tag in your head.html or default.html
@jekyllbot
Copy link
Contributor

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master/main branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@mattr- mattr- added pinned and removed stale labels Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pinned
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattr- @jekyllbot @y377