Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polyPoly flawed #11

Open
polymeris opened this issue Nov 4, 2019 · 4 comments
Open

polyPoly flawed #11

polymeris opened this issue Nov 4, 2019 · 4 comments

Comments

@polymeris
Copy link

I haven't really looked into the details, but playing around with the online version, sometimes when the small polygon is fully inside the larger one, a collision is not detected.

Also, maybe related, you run the following code inside the for-loop, which doesn't make much sense, since it doesn't depend on any of the looped vars, only function parameters:

    // optional: check if the 2nd polygon is INSIDE the first
    collision = polyPoint(p1, p2[0].x, p2[0].y);
    if (collision) return true;

(maybe you wanted to iterate over the vertices of p2?)

@jeffThompson
Copy link
Owner

Sorry, I know this issue is super old now! I can't seem to make this happen – would you mind trying to replicate the issue and record a short video?

@polymeris
Copy link
Author

I am not sure how to record a video. It seems easier to reproduce the bug on a smartphone. The polygon blinks blue as you drag the shape around.

@polymeris
Copy link
Author

Didn't intend to close ticket, always hit the wrong button. (Although feel free to close if you can't repro)

@polymeris polymeris reopened this Apr 21, 2020
@jeffThompson
Copy link
Owner

jeffThompson commented Apr 22, 2020

No worry! I'll take a look on my phone and see if it's a problem for me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants