You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is there a reason why the code is not actually verifying if it's expired but assuming if it exists then its expired?
Comment in ValidatingPushNotificationHandlerFactory.class makes it sound like it will be checked.
* @param expirationTimestampsByDeviceToken a map of device tokens to the time at which they expire; tokens not in
* the map (or all tokens if the map is {@code null} or empty) will never be considered "expired"
The text was updated successfully, but these errors were encountered:
I've looked more closely at this, and this is behaving as expected, though I recognize that the documentation could be clearer. The design intent is that callers can ask the mock server to report that a device token expired at a certain timestamp. The idea is that the timestamp should be in the past, but it's not technically required.
The check you referenced is essentially asking "has somebody specified that this device is expired?" and not "should I perform some time check to see if it is expired?"
I'll think about some ways to rephrase the docs to be clearer, but I do not believe there's any functional problem here.
pushy/pushy/src/main/java/com/eatthepath/pushy/apns/server/ValidatingPushNotificationHandler.java
Lines 139 to 143 in e67df92
Is there a reason why the code is not actually verifying if it's expired but assuming if it exists then its expired?
Comment in
ValidatingPushNotificationHandlerFactory.class
makes it sound like it will be checked.The text was updated successfully, but these errors were encountered: