Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MultipartBodyBuilder #256

Open
andreoss opened this issue Jun 27, 2021 · 7 comments
Open

Remove MultipartBodyBuilder #256

andreoss opened this issue Jun 27, 2021 · 7 comments

Comments

@andreoss
Copy link
Collaborator

andreoss commented Jun 27, 2021

MultipartBodyBuilder [1] is replaceable with StringBuilder or ByteBuffer.

[1] https://github.com/jcabi/jcabi-http/blob/771cf34cb1fbe4d68206c1b6e5ab89808ad1d810/src/main/java/com/jcabi/http/request/MultipartBodyBuilder.java

Replace usage of this class and remove it

@shreegilliorkar
Copy link

@andreoss , I am new in open source contributing can you please tell more detail about this issue like which folder and file do i have to look for the making further changes.

@andreoss
Copy link
Collaborator Author

@Shree-Gillorkar Clarified the issue.

@andreoss
Copy link
Collaborator Author

andreoss commented Jul 1, 2021

@Shree-Gillorkar Are you going to make a PR for this issue?

@shreegilliorkar
Copy link

Hey @andreoss, really sorry about late reply. I thought that issue was clarified means solved. I will work on it & make a pull request as soon as possible.

@shreegilliorkar
Copy link

@andreoss, to clarify this issue i have to replace the function call of MultipartBodyBuilder [1] with which function & after that i will have to remove the class or only function call?

@andreoss
Copy link
Collaborator Author

andreoss commented Jul 3, 2021

@Shree-Gillorkar

  1. Replace usages of MultipartBodyBuilder with StringBuilder
  2. Remove MultipartBodyBuilder

@shreegilliorkar
Copy link

Hey @andreoss , I made the changes you suggested and made a pull request. Please have a look and suggest me if any changes are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants