Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseRequest.java:69-76: Refactor this class to get rid of... #163

Open
0pdd opened this issue Apr 26, 2017 · 1 comment
Open

BaseRequest.java:69-76: Refactor this class to get rid of... #163

0pdd opened this issue Apr 26, 2017 · 1 comment

Comments

@0pdd
Copy link

0pdd commented Apr 26, 2017

The puzzle 87-5547b016 in src/main/java/com/jcabi/http/request/BaseRequest.java (lines 69-76) has to be resolved: Refactor this class to get rid of PMD.GodClass. This can be done if MultiPartFormBody and FormEncodedBody are pulled out. Also, the two share the same implementations for all methods besides formParam, so they can be refactored to extend an AbstractRequestBody. PMD.TooManyMethods might come together with getting rid of the first one, since maybe qulice is counting the methods in the inner classes too - if it doesn't, then it can be left.

The puzzle was created by amihaiemil on 12-Aug-16.

Estimate: 30 minutes, role: IMP.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD.

@0crat
Copy link

0crat commented Apr 26, 2017

@yegor256 please, pay attention to this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants