Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve browser support with tests and slim dependencies #30

Open
jbmusso opened this issue Mar 14, 2016 · 3 comments
Open

Improve browser support with tests and slim dependencies #30

jbmusso opened this issue Mar 14, 2016 · 3 comments

Comments

@jbmusso
Copy link
Owner

jbmusso commented Mar 14, 2016

Browser support should be improved:

  • add appropriate tests
  • remove dependencies/unsure the slimmest possible bundle
@dmill-bz
Copy link
Collaborator

FYI iOS browsers run in strict mode and throw the following error:

Const declarations are not supported in strict mode.

@jbmusso
Copy link
Owner Author

jbmusso commented Mar 19, 2016

This is weird. The code published to npm (and its dependencies) is transpiled to ES5 and shouldn't have any const declarations (only var). Could you be more specific as to how you import the client to your application?

@dmill-bz
Copy link
Collaborator

I originally thought it was because of some of your dependencies (and you excluding node_modules from webpack). But looking at the code again it seems to remove all const appropriately. Wonder why the behavior on gremlin-bin is different. I'll give this another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants