Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

punctuation not being removed correctly using preprocessing.clean #207

Open
aliforgetti opened this issue Apr 13, 2021 · 2 comments
Open

Comments

@aliforgetti
Copy link

This is my code and I was trying to clean a large dataset

full_data['text_pp'] = (
    full_data['text']
    .pipe(hero.preprocessing.clean)
    .pipe(hero.remove_urls)
)

According to the documentation this is the default pipeline for the clean functionality:

Default pipeline:
texthero.preprocessing.fillna()

texthero.preprocessing.lowercase()

texthero.preprocessing.remove_digits()

texthero.preprocessing.remove_punctuation()

texthero.preprocessing.remove_diacritics()

texthero.preprocessing.remove_stopwords()

texthero.preprocessing.remove_whitespace()

But my ouput does not reflect this as some of the punctuation remained in the text.

Original text column
image

Preprocessed text column
image

@henrifroese
Copy link
Collaborator

Hi, could you paste the actual data you're using? (Just one of the texts would help probably).

For me with the beginning of your first text, the punctuation is removed successfully:

>>> import texthero as hero
>>> import pandas as pd
>>> s = pd.Series(["Honestly people don't know about the fact ..."])
>>> hero.clean(s)
0    honestly people know fact
dtype: object

The issue is probably that some punctuation in your text is not "standard" punctuation (texthero internally uses import string; string.punctuation so if it's not in there it won't be removed

@jbesomi
Copy link
Owner

jbesomi commented Apr 16, 2021

Thank you @henrifroese. @aliforgetti do you have any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants