Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version attribute #172

Open
bhishanpdl opened this issue Aug 31, 2020 · 6 comments
Open

Add version attribute #172

bhishanpdl opened this issue Aug 31, 2020 · 6 comments
Labels
good first issue Good for newcomers

Comments

@bhishanpdl
Copy link

Usually python packages has attribute .__version__ and .__name__.

I would suggest adding these two attributes to this package TEXTHERO.

For example:

import numpy as np

print(np.__name__)
print(np.__version__)
@henrifroese henrifroese added the good first issue Good for newcomers label Aug 31, 2020
@henrifroese
Copy link
Collaborator

Makes sense. I believe __name__ is already implemented automatically. Do you want to implement this @bhishanpdl ? You can read here how to start contributing 🎆

@jbesomi
Copy link
Owner

jbesomi commented Aug 31, 2020

Agree with @bhishanpdl, it can be very useful. Actually, even if the task seems very trivial and simple, it's more subtle than that. In a previous version, I implemented this (before this commit) but this was given some problem (setup.cfg required texthero to be installed to install texthero?! 🙃). A better solution than the previous one is required :D

@jbesomi
Copy link
Owner

jbesomi commented Sep 8, 2020

@bhishanpdl want to help with that?

@harishsdev
Copy link

i saw the solution for the above in torchaudio,can i submit PR by porting from torchaudio to texthero

@bhishanpdl
Copy link
Author

@jbesomi and @harishsdev You guys are more than welcome to send the PR to the developers. I would greatly appreciate that.

@jbesomi
Copy link
Owner

jbesomi commented Jul 1, 2021

Hey @harishsdev, sure, if torchaudio has a working solution, it would be great if you can port it to Texthero. Let me know, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants