Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support xref aka cross reference link fix in adoc #623

Open
georgecao opened this issue Mar 4, 2020 · 2 comments · May be fixed by #649
Open

Support xref aka cross reference link fix in adoc #623

georgecao opened this issue Mar 4, 2020 · 2 comments · May be fixed by #649
Milestone

Comments

@georgecao
Copy link
Contributor

I use JBake version 2.6.4 and adoc to write some blog. JBake has two configuration properties to fix relative image src. And they are img.path.update and img.path.prepend.host.

In adoc, I add an image in the doc using image::images/Apache_Thrift_Architecture.png[Thrift], the two properties mentioned above and fix the image src to work fine, especially the blog content is add into the index page.

So in adoc, we also can add a reference to another doc by xref:a-gentle-introduction-to-multithreading.adoc[introduction] , like image , this will generate a <a href='''>...</> tag with relative path. This need fix too.

I am not sure if there are more links to fix in adoc or other type like markdown.

I also found #143 , but it's different from this. So this may need a fix.

@georgecao
Copy link
Contributor Author

I already write some code to fix this like how img src is fixed. But let's make sure it's a problem.
@ancho @jonbullock

@jonbullock
Copy link
Member

Linking #649

@jonbullock jonbullock linked a pull request May 9, 2021 that will close this issue
@jonbullock jonbullock added this to In progress in v2.7.0 Release May 16, 2021
@jonbullock jonbullock added this to the v2.8.0 milestone May 25, 2021
@jonbullock jonbullock removed this from In progress in v2.7.0 Release May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants