Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merging a 3rd party package into django-debug-toolbar #1564

Open
andytwoods opened this issue Dec 21, 2021 · 5 comments
Open

merging a 3rd party package into django-debug-toolbar #1564

andytwoods opened this issue Dec 21, 2021 · 5 comments

Comments

@andytwoods
Copy link

andytwoods commented Dec 21, 2021

Hi there,

if you felt it a good idea, I'd be happy to merge in the features of this extension into your package: https://github.com/andytwoods/mrbenn

This extension lets you click on a view or template link, and have that view/template open in your IDE. I envision there being a toggle within settings where people can specify if they want this feature.

I would just modify your Template and View tools, adding clickable links. The dedicated toolbar provided by mrbenn would then be unnecessary.

cheers,
Andy.

@tim-schilling
Copy link
Contributor

I'm on board with this addition to the TemplatesPanel, @matthiask? It doesn't appear to be a bunch of logic, but rather configuration. It would mean a fair amount of documentation to keep the installation straightforward and quick.

@matthiask
Copy link
Member

I'm not sure. I don't know much about mrbenn but it doesn't seem to be a widely used package, see https://pypistats.org/packages/mrbenn

The package runs a few commands in the background to open files in the IDE, e.g. xdg-open on Linux. I'm slightly against adding code which uses subprocess into the main django-debug-toolbar package.

@andytwoods
Copy link
Author

Just a heads up that we only released mrbenn perhaps a week ago. Maybe the best option is to wait and see how popular mrbenn becomes.

@tim-schilling
Copy link
Contributor

@andytwoods have you looked into implementing extensions for VSCode and PyCharm? I have no idea what that would look like, but I wonder if we could find a different way to implement this.

@andytwoods
Copy link
Author

We've not looked at that possibility. It's a good idea. I'm chock-a-block at the moment so can't explore myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants