Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heroicons SVGs with stroke lines... #33

Closed
macCesar opened this issue Aug 15, 2020 · 9 comments
Closed

Heroicons SVGs with stroke lines... #33

macCesar opened this issue Aug 15, 2020 · 9 comments

Comments

@macCesar
Copy link

Excellent tool!!!... I've created my first font from a bunch of SVGs on the first try!!!

But I have a problem with Heroicons.

The resulting fonts ( at least the .ttf versions ) were not converted correctly because most of the designs contain stroke lines instead of outlines.

Is there a way to auto-convert them to outlines before creating the font file ???

Thanks!!

@jaywcjlove
Copy link
Owner

@macCesar I handled it through Sketch.

@macCesar
Copy link
Author

macCesar commented Aug 15, 2020

Sketch the drawing app ???

I was hopping something automated...

My CLI tool depends on various packages including heroicons ( npm i heroicons ).

So I don't want to edit the SVG files everytime it gets updated! 😬

@macCesar
Copy link
Author

I'm going to test this package:

https://www.npmjs.com/package/svg-outline-stroke

@jaywcjlove
Copy link
Owner

@macCesar Welcome to submit PR. thx!

@macCesar
Copy link
Author

Sure thing!! 👍

@macCesar macCesar changed the title Heroicons SVGs with line strokes... Heroicons SVGs with stroke lines... Aug 15, 2020
@jaywcjlove jaywcjlove pinned this issue Aug 19, 2020
@schmidt-oliver
Copy link

I'm going to test this package:

https://www.npmjs.com/package/svg-outline-stroke

That package didn't work for me. After some days of work i found a solution based on https://docs.oslllo.com/svg-fixer/master/#/ . No changes need in svgtofont.

@jaywcjlove
Copy link
Owner

@schmidt-oliver thx!

https://github.com/oslllo/svg-fixer

@schmidt-oliver
Copy link

I think it can be closed as well.

@jaywcjlove
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants