Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudWatch impl using aws sdk v2 #1022

Open
pethers opened this issue Jun 8, 2021 · 1 comment
Open

CloudWatch impl using aws sdk v2 #1022

pethers opened this issue Jun 8, 2021 · 1 comment

Comments

@pethers
Copy link
Contributor

pethers commented Jun 8, 2021

Hi,

Would be nice with an alternative implementation of
https://github.com/javamelody/javamelody/blob/master/javamelody-core/src/main/java/net/bull/javamelody/internal/publish/CloudWatch.java using https://github.com/aws/aws-sdk-java-v2 .

Currently have to include sdk v1/v2 and only use v1 to get javamelody metrics into cloudwatch.

Happy to try to write an implementation if it exist any interest to get it included.

@evernat
Copy link
Member

evernat commented Jun 10, 2021

Hi James,
Yes, it would be nice if javamelody could be compatible with aws sdk v2.
The best would probably be that javamelody detects automatically if v2 classes are available in the classpath, by using try { Class.forName(aClassAvailableOnlyInV2); } catch (ClassNotFoundException e) { // no v2 }, with the same javamelody parameters as with v1.
And if v2 is available, a CloudWatch2 class could be used instead of the CloudWatch class or the CloudWatch class itself could use aws v2 perhaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants