Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: LinksTo doesn't work with YAML wikilinks in Obsidian 1.4 #414

Open
3 of 7 tasks
kepano opened this issue Aug 4, 2023 · 3 comments
Open
3 of 7 tasks

[Bug]: LinksTo doesn't work with YAML wikilinks in Obsidian 1.4 #414

kepano opened this issue Aug 4, 2023 · 3 comments
Assignees
Labels
Type: Bug A problem with existing functionality.

Comments

@kepano
Copy link

kepano commented Aug 4, 2023

Check for existing bug reports before submitting.

  • I searched for existing Bug Reports and found no similar reports.

Expected Behavior

Obsidian 1.4 adds support for internal links
https://obsidian.md/changelog/2023-07-26-desktop-v1.4.0/

It appears that the query is not correctly accessing the links in YAML. Dataview does seem to be able to access these though.

Current behaviour

LinksTo does not display notes that are linked to the specified note

Reproduction

Example query

id: tokyo
linksTo: [[Tokyo]]

Note content

---
location: [139.7657382, 35.6712864]
city: '[[Tokyo]]'
---

Which Operating Systems are you using?

  • Android
  • iPhone/iPad
  • Linux
  • macOS
  • Windows

Obsidian Version Check

1.4.2

Plugin Version

5.7.2

Confirmation

  • I have disabled all other plugins and the issue still persists.

Possible solution

No response

@kepano kepano added the bug label Aug 4, 2023
@valentine195
Copy link
Member

valentine195 commented Aug 5, 2023

The plugin uses Obsidian’s API to resolve linksTo / linksFrom:

for (let link of linksTo) {

which then uses Dataview to get the link map.

If Dataview’s API changed, I’ll have to resync it.

@valentine195 valentine195 self-assigned this Aug 5, 2023
@sigrunixia sigrunixia added Type: Bug A problem with existing functionality. and removed bug labels Aug 11, 2023
@valentine195
Copy link
Member

@kepano I did some testing of this this morning, and Leaflet successfully identifies the file. I looked at the DV cache and this setup is not created as an in-link to the Tokyo file. I think this is an issue with Dataview.

@KiljanK
Copy link

KiljanK commented Sep 11, 2023

As far as i'm aware, this is a Dataview issue indeed.

There has been a recent PR to fix this issue, but it failed two tests.

I don't know how long this usually takes, but this looks like a good sign :)

EDIT: It has just been fixed in the most recent release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug A problem with existing functionality.
Projects
None yet
Development

No branches or pull requests

4 participants